Fix type_id_hasher test, Increase Minimum Supported Rust Version to 1.56, Use edition 2021 - #7
Merged
Conversation
Signed-off-by: Olivier 'reivilibre <git.oo@emunest.net>
Signed-off-by: Olivier 'reivilibre <git.oo@emunest.net>
reivilibre
changed the title
type_id_hasher test, Increase Minimum Supported Rust Version to 1.56, Use edition 2021
Signed-off-by: Olivier 'reivilibre <git.oo@emunest.net>
The runtime behaviour is still correct; it's only our test assertion that was dodgy Signed-off-by: Olivier 'reivilibre <git.oo@emunest.net>
Signed-off-by: Olivier 'reivilibre <git.oo@emunest.net>
Signed-off-by: Olivier 'reivilibre <git.oo@emunest.net>
Signed-off-by: Olivier 'reivilibre <git.oo@emunest.net>
Signed-off-by: Olivier 'reivilibre <git.oo@emunest.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
type_id_hashertest was tightly coupled to stdlib memory layout. It still is, but now accepts both old and new layout.panic!. But it turns out 1.56 still doesn't support that properly inassert!... Still, 1.56 is nearly 5 years old, I think it's OK to bump a bit.